Feature / Columnar data C API #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
…aset. `main_model_impl` still lacks functionality to accommodate columnar data input Signed-off-by: Jerry Guo <[email protected]>
power_grid_model_c/power_grid_model_c/include/power_grid_model_c/dataset.h
Show resolved
Hide resolved
Signed-off-by: Jerry Guo <[email protected]>
…aset`, updated relevant api calls Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
mgovers
changed the base branch from
main
to
feature/main-model-columnar-data
Signed-off-by: Martijn Govers <[email protected]>
…le-dataset' into feature/columnar-data-c-api Signed-off-by: Martijn Govers <[email protected]>
mgovers
force-pushed
the
feature/columnar-data-c-api
branch
from
2001844 to
874c770
Compare
mgovers
reviewed
Sep 10, 2024
power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/dataset.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Martijn Govers <[email protected]>
mgovers
reviewed
Sep 10, 2024
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
An error occurred while trying to automatically change base from
feature/main-model-columnar-data
to
main
September 10, 2024 09:59
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/dataset.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model_cpp/include/power_grid_model_cpp/handle.hpp
Show resolved
Hide resolved
mgovers
reviewed
Sep 16, 2024
power_grid_model_c/power_grid_model_c/include/power_grid_model_c/dataset.h
Show resolved
Hide resolved
Signed-off-by: Jerry Guo <[email protected]>
TonyXiang8787
requested changes
Sep 16, 2024
There was a problem hiding this comment.
@Jerry-Jinfeng-Guo please resolve the merge conflict and we should be good to go
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
|
Hmmm. buffer overflow... |
Signed-off-by: Jerry Guo <[email protected]>
Fixed... |
|
TonyXiang8787
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements C API changes in #548
capi tests